[html5] r5824 - [e] (0) remove redundant step Fixing http://www.w3.org/Bugs/Public/show_bug.cgi? [...]

whatwg at whatwg.org whatwg at whatwg.org
Thu Feb 3 13:05:14 PST 2011


Author: ianh
Date: 2011-02-03 13:05:13 -0800 (Thu, 03 Feb 2011)
New Revision: 5824

Modified:
   complete.html
   index
   source
Log:
[e] (0) remove redundant step
Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=11643

Modified: complete.html
===================================================================
--- complete.html	2011-02-03 21:01:06 UTC (rev 5823)
+++ complete.html	2011-02-03 21:05:13 UTC (rev 5824)
@@ -30421,11 +30421,14 @@
    integer. Let <var title="">value<sub>4</sub></var> be that
    integer.</li>
 
-   <li><p>If <var title="">value<sub>2</sub></var> is greater than 59,
-   if <var title="">value<sub>3</sub></var> is greater than 59, or if
-   <var title="">value<sub>4</sub></var> is greater than 999, return
-   an error and abort these steps.</li>
+   <li><p>If <var title="">value<sub>2</sub></var> is greater than 59
+   or if <var title="">value<sub>3</sub></var> is greater than 59,
+   return an error and abort these steps.</li>
 
+   <!-- no need to check if <var title="">value<sub>4</sub></var> is
+   greater than 999, since we know it had exactly three characters in
+   the range 0-9, so we know it's a number in the range 0-999 -->
+
    <li><p>Let <var title="">result</var> be <span title=""><var title="">value<sub>1</sub></var>×60×60 + <var title="">value<sub>2</sub></var>×60 + <var title="">value<sub>3</sub></var> + <var title="">value<sub>4</sub></var>∕1000</span>. <!-- &#x00f7;
    is the division sign if people prefer that to the slash
    --></li>

Modified: index
===================================================================
--- index	2011-02-03 21:01:06 UTC (rev 5823)
+++ index	2011-02-03 21:05:13 UTC (rev 5824)
@@ -30403,11 +30403,14 @@
    integer. Let <var title="">value<sub>4</sub></var> be that
    integer.</li>
 
-   <li><p>If <var title="">value<sub>2</sub></var> is greater than 59,
-   if <var title="">value<sub>3</sub></var> is greater than 59, or if
-   <var title="">value<sub>4</sub></var> is greater than 999, return
-   an error and abort these steps.</li>
+   <li><p>If <var title="">value<sub>2</sub></var> is greater than 59
+   or if <var title="">value<sub>3</sub></var> is greater than 59,
+   return an error and abort these steps.</li>
 
+   <!-- no need to check if <var title="">value<sub>4</sub></var> is
+   greater than 999, since we know it had exactly three characters in
+   the range 0-9, so we know it's a number in the range 0-999 -->
+
    <li><p>Let <var title="">result</var> be <span title=""><var title="">value<sub>1</sub></var>×60×60 + <var title="">value<sub>2</sub></var>×60 + <var title="">value<sub>3</sub></var> + <var title="">value<sub>4</sub></var>∕1000</span>. <!-- &#x00f7;
    is the division sign if people prefer that to the slash
    --></li>

Modified: source
===================================================================
--- source	2011-02-03 21:01:06 UTC (rev 5823)
+++ source	2011-02-03 21:05:13 UTC (rev 5824)
@@ -33244,11 +33244,14 @@
    integer. Let <var title="">value<sub>4</sub></var> be that
    integer.</p></li>
 
-   <li><p>If <var title="">value<sub>2</sub></var> is greater than 59,
-   if <var title="">value<sub>3</sub></var> is greater than 59, or if
-   <var title="">value<sub>4</sub></var> is greater than 999, return
-   an error and abort these steps.</p></li>
+   <li><p>If <var title="">value<sub>2</sub></var> is greater than 59
+   or if <var title="">value<sub>3</sub></var> is greater than 59,
+   return an error and abort these steps.</p></li>
 
+   <!-- no need to check if <var title="">value<sub>4</sub></var> is
+   greater than 999, since we know it had exactly three characters in
+   the range 0-9, so we know it's a number in the range 0-999 -->
+
    <li><p>Let <var title="">result</var> be <span title=""><var
    title="">value<sub>1</sub></var>×60×60 + <var
    title="">value<sub>2</sub></var>×60 + <var




More information about the Commit-Watchers mailing list