[html5] r3299 - [] (0) Roll in the various notes I'd made about menu construction into the algorithm.

whatwg at whatwg.org whatwg at whatwg.org
Tue Jun 16 22:52:51 PDT 2009


Author: ianh
Date: 2009-06-16 22:52:46 -0700 (Tue, 16 Jun 2009)
New Revision: 3299

Modified:
   index
   source
Log:
[] (0) Roll in the various notes I'd made about menu construction into the algorithm.

Modified: index
===================================================================
--- index	2009-06-17 05:34:51 UTC (rev 3298)
+++ index	2009-06-17 05:52:46 UTC (rev 3299)
@@ -38784,17 +38784,17 @@
 
   <dl class=switch><dt>An element that <a href=#concept-command title=concept-command>defines a command</a></dt>
 
-   <dd>Append the command to the menu, respecting its <a href=#concept-facet title=concept-facet>facets</a><!-- XXX be explicit about what
-   this means for each facet -->. <!--If the element is a
-   <code>command</code> element with a <code
-   title="attr-command-default">default</code> attribute, mark the
-   command as being a default command.--></dd> <!-- XXX if there's an
-   Icon facet for the command, it should be <span
-   title="fetch">fetched</span>, and then that image should be
-   associated with the command, such that each command only has its
-   image fetched once, to prevent changes to the base URL from having
-   effects after the image has been fetched once. (no need to resolve
-   the Icon facet, it's an absolute URL) -->
+   <dd>Append the command to the menu, respecting its <a href=#concept-facet title=concept-facet>facets</a><!-- we might need to be
+   explicit about what this means for each facet, if testing shows
+   this isn't well-implemented. e.g.: If there's an Icon facet for the
+   command, it should be <span title="fetch">fetched</span>, and then
+   that image should be associated with the command, such that each
+   command only has its image fetched once, to prevent changes to the
+   base URL from having effects after the image has been fetched
+   once. (no need to resolve the Icon facet, it's an absolute URL)
+   -->. <!--If the element is a <code>command</code> element with a
+   <code title="attr-command-default">default</code> attribute, mark
+   the command as being a default command.--></dd>
 
 
    <dt>An <code><a href=#the-hr-element>hr</a></code> element</dt>
@@ -38807,8 +38807,9 @@
 
 
    <dt>An <code><a href=#the-li-element>li</a></code> element</dt>
+   <dt>A <code><a href=#the-label-element>label</a></code> element</dt>
 
-   <dd>Iterate over the children of the <code><a href=#the-li-element>li</a></code> element.</dd>
+   <dd>Iterate over the children of the element.</dd>
 
 
    <dt>A <code><a href=#menus>menu</a></code> element with no <code title=attr-menu-label><a href=#attr-menu-label>label</a></code> attribute</dt>
@@ -38817,10 +38818,11 @@
    <dd>Append a separator to the menu, then iterate over the children
    of the <code><a href=#menus>menu</a></code> or <code><a href=#the-select-element>select</a></code> element, then
    append another separator.</dd>
+   <!-- v2: we might want to support <select> in <label> as giving a named submenu -->
 
 
    <dt>A <code><a href=#menus>menu</a></code> element with a <code title=attr-menu-label><a href=#attr-menu-label>label</a></code> attribute</dt>
-   <dt>An <code><a href=#the-optgroup-element>optgroup</a></code> element</dt>
+   <dt>An <code><a href=#the-optgroup-element>optgroup</a></code> element with a <code title=attr-menu-label><a href=#attr-menu-label>label</a></code> attribute</dt>
 
    <dd>Append a submenu to the menu, using the value of the element's
    <code title="">label</code> attribute as the label of the menu. The
@@ -38833,16 +38835,7 @@
 
    <dd><a href=#ignore>Ignore</a> the node.</dd>
 
-  </dl><p class=XXX>We should support <code><a href=#the-label-element>label</a></code> in the
-  algorithm above -- just iterate through the contents like with
-  <code><a href=#the-li-element>li</a></code>, to support <code><a href=#the-input-element>input</a></code> elements in
-  <code><a href=#the-label-element>label</a></code> elements. Also, <code><a href=#the-optgroup-element>optgroup</a></code> elements
-  without labels should be ignored (maybe? or at least should say they
-  have no label so that they are dropped below), and
-  <code><a href=#the-select-element>select</a></code> elements inside <code><a href=#the-label-element>label</a></code> elements may
-  need special processing.</p>
-
-  <p>Once all the nodes have been processed as described above, the
+  </dl><p>Once all the nodes have been processed as described above, the
   user agent must the post-process the menu as follows:</p>
 
   <ol><li>Any menu item with no label, or whose label is the empty string, must be removed.</li>

Modified: source
===================================================================
--- source	2009-06-17 05:34:51 UTC (rev 3298)
+++ source	2009-06-17 05:52:46 UTC (rev 3299)
@@ -43548,17 +43548,17 @@
    <dt>An element that <span title="concept-command">defines a command</span></dt>
 
    <dd>Append the command to the menu, respecting its <span
-   title="concept-facet">facets</span><!-- XXX be explicit about what
-   this means for each facet -->. <!--If the element is a
-   <code>command</code> element with a <code
-   title="attr-command-default">default</code> attribute, mark the
-   command as being a default command.--></dd> <!-- XXX if there's an
-   Icon facet for the command, it should be <span
-   title="fetch">fetched</span>, and then that image should be
-   associated with the command, such that each command only has its
-   image fetched once, to prevent changes to the base URL from having
-   effects after the image has been fetched once. (no need to resolve
-   the Icon facet, it's an absolute URL) -->
+   title="concept-facet">facets</span><!-- we might need to be
+   explicit about what this means for each facet, if testing shows
+   this isn't well-implemented. e.g.: If there's an Icon facet for the
+   command, it should be <span title="fetch">fetched</span>, and then
+   that image should be associated with the command, such that each
+   command only has its image fetched once, to prevent changes to the
+   base URL from having effects after the image has been fetched
+   once. (no need to resolve the Icon facet, it's an absolute URL)
+   -->. <!--If the element is a <code>command</code> element with a
+   <code title="attr-command-default">default</code> attribute, mark
+   the command as being a default command.--></dd>
 
 
    <dt>An <code>hr</code> element</dt>
@@ -43573,8 +43573,9 @@
 
 
    <dt>An <code>li</code> element</dt>
+   <dt>A <code>label</code> element</dt>
 
-   <dd>Iterate over the children of the <code>li</code> element.</dd>
+   <dd>Iterate over the children of the element.</dd>
 
 
    <dt>A <code>menu</code> element with no <code title="attr-menu-label">label</code> attribute</dt>
@@ -43583,10 +43584,11 @@
    <dd>Append a separator to the menu, then iterate over the children
    of the <code>menu</code> or <code>select</code> element, then
    append another separator.</dd>
+   <!-- v2: we might want to support <select> in <label> as giving a named submenu -->
 
 
    <dt>A <code>menu</code> element with a <code title="attr-menu-label">label</code> attribute</dt>
-   <dt>An <code>optgroup</code> element</dt>
+   <dt>An <code>optgroup</code> element with a <code title="attr-menu-label">label</code> attribute</dt>
 
    <dd>Append a submenu to the menu, using the value of the element's
    <code title="">label</code> attribute as the label of the menu. The
@@ -43601,15 +43603,6 @@
 
   </dl>
 
-  <p class="XXX">We should support <code>label</code> in the
-  algorithm above -- just iterate through the contents like with
-  <code>li</code>, to support <code>input</code> elements in
-  <code>label</code> elements. Also, <code>optgroup</code> elements
-  without labels should be ignored (maybe? or at least should say they
-  have no label so that they are dropped below), and
-  <code>select</code> elements inside <code>label</code> elements may
-  need special processing.</p>
-
   <p>Once all the nodes have been processed as described above, the
   user agent must the post-process the menu as follows:</p>
 




More information about the Commit-Watchers mailing list