[html5] r8344 - [giow] (0) Make non-scripted <dialog> closing not throw uncaught exceptions. Fix [...]
whatwg at whatwg.org
whatwg at whatwg.org
Wed Dec 11 13:36:12 PST 2013
Author: ianh
Date: 2013-12-11 13:36:10 -0800 (Wed, 11 Dec 2013)
New Revision: 8344
Modified:
complete.html
index
source
Log:
[giow] (0) Make non-scripted <dialog> closing not throw uncaught exceptions.
Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=23478
Affected topics: CSS, HTML
Modified: complete.html
===================================================================
--- complete.html 2013-12-11 21:23:36 UTC (rev 8343)
+++ complete.html 2013-12-11 21:36:10 UTC (rev 8344)
@@ -48979,7 +48979,8 @@
<p>Let <var title="">subject</var> be the nearest ancestor <code><a href=#the-dialog-element>dialog</a></code> element of <var title="">form</var>, if any.</p>
- <p>If there isn't one, do nothing. Otherwise, proceed as follows:</p>
+ <p>If there isn't one, or if it does not have an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+ attribute, do nothing. Otherwise, proceed as follows:</p>
<p>If <var title="">submitter</var> is an <code><a href=#the-input-element>input</a></code> element whose <code title=attr-input-type><a href=#attr-input-type>type</a></code> attribute is in the <a href="#image-button-state-(type=image)" title=attr-input-type-image>Image Button</a> state, then let <var title="">result</var>
be the string formed by concatenating the <a href=#concept-input-type-image-coordinate title=concept-input-type-image-coordinate>selected coordinate</a>'s <var title="">x</var>-component, expressed as a base-ten number using <a href=#ascii-digits>ASCII digits</a>, a
@@ -51154,7 +51155,8 @@
<hr><p><strong>Canceling dialogs</strong>: When a <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog
stack</a> is not empty, user agents may provide a user interface that, upon activation, <a href=#queue-a-task title="queue a task">queues a task</a> to <a href=#fire-a-simple-event>fire a simple event</a> named <dfn id=event-cancel title=event-cancel><code>cancel</code></dfn> that is cancelable at the top <code><a href=#the-dialog-element>dialog</a></code>
element on the <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog stack</a>. The default action of
- this event must be to <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
+ this event must be to check if that element has an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+ attribute, and if it does, <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
<p class=note>An example of such a UI mechanism would be the user pressing the "Escape" key.</p>
Modified: index
===================================================================
--- index 2013-12-11 21:23:36 UTC (rev 8343)
+++ index 2013-12-11 21:36:10 UTC (rev 8344)
@@ -48979,7 +48979,8 @@
<p>Let <var title="">subject</var> be the nearest ancestor <code><a href=#the-dialog-element>dialog</a></code> element of <var title="">form</var>, if any.</p>
- <p>If there isn't one, do nothing. Otherwise, proceed as follows:</p>
+ <p>If there isn't one, or if it does not have an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+ attribute, do nothing. Otherwise, proceed as follows:</p>
<p>If <var title="">submitter</var> is an <code><a href=#the-input-element>input</a></code> element whose <code title=attr-input-type><a href=#attr-input-type>type</a></code> attribute is in the <a href="#image-button-state-(type=image)" title=attr-input-type-image>Image Button</a> state, then let <var title="">result</var>
be the string formed by concatenating the <a href=#concept-input-type-image-coordinate title=concept-input-type-image-coordinate>selected coordinate</a>'s <var title="">x</var>-component, expressed as a base-ten number using <a href=#ascii-digits>ASCII digits</a>, a
@@ -51154,7 +51155,8 @@
<hr><p><strong>Canceling dialogs</strong>: When a <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog
stack</a> is not empty, user agents may provide a user interface that, upon activation, <a href=#queue-a-task title="queue a task">queues a task</a> to <a href=#fire-a-simple-event>fire a simple event</a> named <dfn id=event-cancel title=event-cancel><code>cancel</code></dfn> that is cancelable at the top <code><a href=#the-dialog-element>dialog</a></code>
element on the <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog stack</a>. The default action of
- this event must be to <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
+ this event must be to check if that element has an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+ attribute, and if it does, <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
<p class=note>An example of such a UI mechanism would be the user pressing the "Escape" key.</p>
Modified: source
===================================================================
--- source 2013-12-11 21:23:36 UTC (rev 8343)
+++ source 2013-12-11 21:36:10 UTC (rev 8344)
@@ -53875,7 +53875,8 @@
<p>Let <var data-x="">subject</var> be the nearest ancestor <code>dialog</code> element of <var
data-x="">form</var>, if any.</p>
- <p>If there isn't one, do nothing. Otherwise, proceed as follows:</p>
+ <p>If there isn't one, or if it does not have an <code data-x="attr-dialog-open">open</code>
+ attribute, do nothing. Otherwise, proceed as follows:</p>
<p>If <var data-x="">submitter</var> is an <code>input</code> element whose <code
data-x="attr-input-type">type</code> attribute is in the <span
@@ -56466,7 +56467,8 @@
data-x="queue a task">queues a task</span> to <span>fire a simple event</span> named <dfn
data-x="event-cancel"><code>cancel</code></dfn> that is cancelable at the top <code>dialog</code>
element on the <code>Document</code>'s <span>pending dialog stack</span>. The default action of
- this event must be to <span>close the dialog</span> with no return value.</p>
+ this event must be to check if that element has an <code data-x="attr-dialog-open">open</code>
+ attribute, and if it does, <span>close the dialog</span> with no return value.</p>
<p class="note">An example of such a UI mechanism would be the user pressing the "Escape" key.</p>
More information about the Commit-Watchers
mailing list