[whatwg] feedback on 4.11.2.x

[Ian Hickson]

On Mon, Apr 20, 2009 at 8:29 AM, Blake Frantz <bfrantz at cisecurity.org> wrote:
>
> In section '4.11.2 The datagrid element'
>
> "However, conformance requirements stating that datagrid elements must react to users in particular ways do not apply when one is disabled."
>
> s/one/the given datagrid/

Fixed.


> In section '4.11.2.2 Populating the datagrid' beneath 'datagrid . sortAscending [ = value ]'
>
> "Returns true if the data is to be sorted with small values first; otherwise, returns false, indicating that bigger values are to be put first."
>
> s/small/smaller/

Fixed.


> In section '4.11.2.2.3 The rows" beneath "The insertRows(rows) method must run the following steps:"
>
> " or the datagrid itself it the Row object's RowID has length 0."
>
> s/it/if/

Fixed.


> Same section, beneath "An open flag"
>
> "Once set, can only be changed ..." => "Once set, the open flag can only be changed ..."

Fixed.


> Same section, beneath "The setRows(rows) method must run the following steps:"
>
> "
> ...
> If one of the following conditions is true, then revert all the changes done in this step, throw a DATAGRID_MODEL_ERR exception, and abort these steps:
> o The value of the Row object's second entry is neither -1 nor equal to the child count of the preexisting row.
> o The Row object has fewer than five entries, or its fifth entry is false.
> o The Row object has fewer than six entries, or its sixth entry is not equal to the row count of the preexisting row.
> ...
> "
> I read the above as:
>
>        1. Abort if the value of the Row object's second entry is neither -1 nor equal to the child count of the preexisting row.
>        2. Abort if the Row object has fewer than five entries.
>        3. Abort if the Row object has at least five entries and the fifth is false.
>        4. Abort if the Row object has fewer than six entries.
>        5. Abort if the Row object has at least six entries and the sixth is not equal to the row count of the preexisting row.
>
> In this interpretation, 2 and 3 are superfluous given 4.

Good catch. Fixed.

--
Ian Hickson