[whatwg] Feedback on UndoManager spec

[Ryosuke Niwa]

On Wed, Oct 26, 2011 at 11:06 PM, Jonas Sicking <jonas at sicking.cc> wrote:

> On Wed, Oct 26, 2011 at 9:06 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> > The problem is that if the undo manager has automatic transactions in
> them,
> > then they'll have references to nodes to undo/redo transactions. But
> those
> > nodes's owner document is still that of the old document. At least in
> > WebKit, this will be a bit of an issue.
>
> The way that the DOM4 spec is written these days, those nodes will get
> automatically adopted when they are inserted into the new document.
>
> If webkit has limitations around that, those limitations needs to be
> fixed anyway in order to implement DOM4 correctly.
>

Interesting. I've done some quick testing but maybe problems I had in mind
no longer exist in WebKit. We do a poor job on node adoption and lifetime
control so this might be a good opportunity to sort them out anyway.

- Ryosuke