[whatwg] Comments on <dialog>

Matt Falkenhagen falken at chromium.org
Sat Nov 2 19:59:49 PDT 2013


On Fri, Sep 27, 2013 at 7:15 AM, Ian Hickson <ian at hixie.ch> wrote:

> On Mon, 26 Aug 2013, Matt Falkenhagen wrote:
> > Changing the static position after layout breaks much assumptions in the
> > code and would seem to require invasive work across the render tree,
> > layer tree, possibly painting, etc. In contrast, if CSS is manipulated
> > after the first layout pass, the layout engine just works. So I found it
> > convenient and stable to mutate CSS 'top' directly.
>
> I don't think mutating attributes is a sane approach to doing this. It
> feels like a hack, it interferes with author affordances, it makes it
> harder for us to distinguish script-set property values from UA-set
> property values, it makes it harder for authors to specifically override
> the UA, etc.
>

I changed this in Blink to match the spec. Now dialog centering sets the
static position instead of the computed 'top' value.



More information about the whatwg mailing list